Conversation
Fixes #613 - psql flags like -h, -U, -d, -c were being interpreted as rtk options instead of being forwarded to psql. By disabling the automatic help flag, psql's own flags can pass through correctly. Users can still access psql help via 'rtk psql --help'.
Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: zerone0x <hi@trine.dev>
- codebase more clear for humans and AI agents - alignement on vision and filter quality in technical docs
…folders-and-documentation
Signed-off-by: Ахмедов Нурбек Медетбаевич <n.akhmedov@uzdc.uz>
…folders-and-documentation
feat(refacto-codebase-onboarding): partie 1 - folders and technical docs
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rtk ls | wc -l returned N+2 instead of N because the summary line (📊 X files, Y dirs) and blank line were always written to stdout. Now uses std::io::stdout().is_terminal() to suppress the summary when piped, following standard Unix convention (ls, grep, find all do this). Fixes #482 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ousama Ben Younes <benyounes.ousama@gmail.com>
Avoids one allocation since entries is not used after the if/else. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ousama Ben Younes <benyounes.ousama@gmail.com>
Fixes Documentation Validation CI check (main.rs=64, ARCHITECTURE.md was 60). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ousama Ben Younes <benyounes.ousama@gmail.com>
Signed-off-by: Roopesh <roopesh1724989@gmail.com>
cat flags like -v, -A, -e, -t, -s have different semantics than rtk read flags (-v means verbose, -n means line numbers). Blindly forwarding flags caused incorrect behavior (e.g. cat -A file → rtk read -A file which fails). Only skip rewrite for incompatible flags. cat -n (line numbers) maps correctly to rtk read -n, so it is still rewritten for token savings. Plain `cat file` continues to rewrite to `rtk read file` as before.
pszymkowiak
reviewed
Mar 27, 2026
Collaborator
pszymkowiak
left a comment
There was a problem hiding this comment.
Review — PR #869: Codebase refactoring (Part 1)
What it does
Major reorganization of the Rust codebase into a cleaner structure:
src/*.rsflat files → organized into submodules:src/analytics/— cc_economics, ccusage, gain, session_cmdsrc/cmds/— grouped by ecosystem (cloud, dotnet, git, go, js, python, ruby, rust, system)
hooks/— organized by IDE (claude, cline, codex, copilot, cursor, opencode)- Docs updated: ARCHITECTURE.md, CLAUDE.md, CONTRIBUTING.md, TECHNICAL.md
Stats
- 100 files changed, 56 Rust files
- No logic changes — pure file moves + mod.rs wiring
- CI: 17/17 checks passing
Assessment
LGTM. This is a clean structural refactor:
- ✅ Ecosystem-based grouping makes sense (git, js, rust, python, etc.)
- ✅ Analytics separated from commands
- ✅ Hooks organized by IDE/tool
- ✅ All CI passing
- ✅ Docs updated to match new structure
Minor concerns
- The
src/cmds/split means new contributors need to know which ecosystem a filter belongs to — the CONTRIBUTING.md update addresses this - Make sure
cargo docstill generates correctly with the new module paths - Part 2 should probably move
core/(tracking, config, filter, tee, utils) as mentioned in ARCHITECTURE.md
No blockers. Ready to merge.
As of go v1.24, tools such as golanci-lint can be managed via the mod file and called directly on the go binary via the tool subcommand. When called via tools, we now apply the same logic to compact the results as in the directly called command. Signed-off-by: shwoop <monkey.mambo.al.ferguson@gmail.com>
fix(ls): suppress summary line when stdout is piped
LGTM. Correct fix — Clap's command graph can overflow the default 1MB Windows stack. /STACK:8388608 is a standard mitigation.
Docs correct — branch names use slash prefixes, not conventional-commit format in parentheses.
|
Ахмедов Нурбек Медетбаевич seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Correct fix. UTC timestamps in a local CLI history view is a UX bug — chrono::Local is already a dependency.
Correct fix. disable_help_flag = true is the right pattern for passthrough commands — consistent with other commands in the codebase.
…n-cargo-output Correct. The Finished line carries useful signal (build time + profile). Defensive implementation with Option fallback.
Standard portability fix. /bin/bash is not guaranteed on NixOS or macOS with Homebrew bash. /usr/bin/env bash is the correct practice.
…or-details LGTM after code review. truncate() correctly imported, error_details block placed before rule frequency table, test covers the main case. Minor duplication for error[Exxxx] style but not a bug.
Correct fix. cat flags like -A/-v/-e have no rtk read equivalent — skipping rewrite is the right behavior. cat -n correctly preserved. Well tested.
feat(go): Support golangci-lint via go tool
fix(security): salt device hash for telemetry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 1 of codebase refacto for better onboarding, cleaner code for an extensible and collaborative codebase